From b1d432413a7c5744e02a319a347c295c19980237 Mon Sep 17 00:00:00 2001 From: MihailRis Date: Tue, 28 Nov 2023 12:50:06 +0300 Subject: [PATCH 1/2] scissor test fix --- src/window/Window.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/window/Window.cpp b/src/window/Window.cpp index eccdb44b..ad221942 100644 --- a/src/window/Window.cpp +++ b/src/window/Window.cpp @@ -178,7 +178,9 @@ void Window::pushScissor(vec4 area) { if (area.z < 0.0f || area.w < 0.0f) { glScissor(0, 0, 0, 0); } else { - glScissor(area.x, Window::height-area.w, area.z-area.x, area.w-area.y); + glScissor(area.x, Window::height-area.w, + std::max(0, int(area.z-area.x)), + std::max(0, int(area.w-area.y))); } scissorArea = area; } @@ -193,7 +195,9 @@ void Window::popScissor() { if (area.z < 0.0f || area.w < 0.0f) { glScissor(0, 0, 0, 0); } else { - glScissor(area.x, Window::height-area.w, area.z-area.x, area.w-area.y); + glScissor(area.x, Window::height-area.w, + std::max(0, int(area.z-area.x)), + std::max(0, int(area.w-area.y))); } if (scissorStack.empty()) { glDisable(GL_SCISSOR_TEST); From e6ecd558a932a593267c4cb6f182a490447b3e54 Mon Sep 17 00:00:00 2001 From: MihailRis Date: Tue, 28 Nov 2023 12:56:25 +0300 Subject: [PATCH 2/2] fixed planet rotation direction --- src/frontend/graphics/Skybox.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/graphics/Skybox.cpp b/src/frontend/graphics/Skybox.cpp index dcee7137..08e2fff0 100644 --- a/src/frontend/graphics/Skybox.cpp +++ b/src/frontend/graphics/Skybox.cpp @@ -86,7 +86,7 @@ void Skybox::refresh(float t, float mie, uint quality) { shader->uniform1i("u_quality", quality); shader->uniform1f("u_mie", mie); - shader->uniform3f("u_lightDir", glm::normalize(vec3(sin(t), -cos(t), 0.7f))); + shader->uniform3f("u_lightDir", glm::normalize(vec3(sin(t), -cos(t), -0.7f))); for (uint face = 0; face < 6; face++) { glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, cubemap, 0); glClear(GL_COLOR_BUFFER_BIT);