From 73e721513caa0b736ca3a47af519b2d5b916111f Mon Sep 17 00:00:00 2001 From: Vyacheslav Ivanov Date: Thu, 1 Aug 2024 23:35:13 +0300 Subject: [PATCH] fix: optimization: PVS-Studio warning V836 Expression's value is copied at variable declaration. The variable is never modified. Consider declaring it as a reference. Changed variables to be a reference to avoid unnecessary copy. Reported by: PVS-Studio Signed-off-by: Vyacheslav Ivanov --- src/content/ContentLoader.cpp | 2 +- src/graphics/ui/gui_xml.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/content/ContentLoader.cpp b/src/content/ContentLoader.cpp index 448754a2..a156d6ab 100644 --- a/src/content/ContentLoader.cpp +++ b/src/content/ContentLoader.cpp @@ -85,7 +85,7 @@ bool ContentLoader::fixPackIndices( indexed.push_back(name); } } - for (auto name : detected) { + for (const auto &name : detected) { if (!util::contains(indexed, name)) { arr->put(name); modified = true; diff --git a/src/graphics/ui/gui_xml.cpp b/src/graphics/ui/gui_xml.cpp index 297ee4ac..637b2220 100644 --- a/src/graphics/ui/gui_xml.cpp +++ b/src/graphics/ui/gui_xml.cpp @@ -203,7 +203,7 @@ static void _readPanel(UiXmlReader& reader, const xml::xmlelement& element, Pane panel.setMaxLength(element->attr("max-length").asInt()); } if (element->has("orientation")) { - auto oname = element->attr("orientation").getText(); + const auto &oname = element->attr("orientation").getText(); if (oname == "horizontal") { panel.setOrientation(Orientation::horizontal); }