PulseStudio/VoxelEngine
PulseStudio/VoxelEngine
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: optimization: PVS-Studio warning V801

Browse Source 
Redefined the second function argument as a const reference instead of by value to improve performance.

Reported by: PVS-Studio
Signed-off-by: Vyacheslav Ivanov <islavaivanov76@gmail.com>
This commit is contained in:
Vyacheslav Ivanov 2024-08-02 06:18:05 +03:00 committed by Pugemon
parent c3e4341a04
commit 35d26a771f
No known key found for this signature in database
GPG Key ID: 472FA343B3CC3287
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/files/files.cpp
View File

@ -103,7 +103,7 @@ std::string files::read_string(const fs::path& filename) {
return std::string((const char*)bytes.get(), size);
}
bool files::write_string(const fs::path& filename, const std::string content) {
bool files::write_string(const fs::path& filename, const std::string& content) {
std::ofstream file(filename);
if (!file) {
return false;

2
src/files/files.hpp
View File

@ -40,7 +40,7 @@ namespace files {
uint append_bytes(const fs::path& file, const ubyte* data, size_t size);
/// @brief Write string to the file
bool write_string(const fs::path& filename, const std::string content);
bool write_string(const fs::path& filename, const std::string& content);
/// @brief Write dynamic data to the JSON file
/// @param nice if true, human readable format will be used, otherwise minimal