From 4df6150692456f816af82ee6faf414bbdddc9cab Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Wed, 14 May 2025 07:01:33 +0300
Subject: [PATCH 01/11] make code editor filter pattern-safe & update
 script_file template

---
 res/layouts/code_editor.xml.lua       | 14 ++++++++------
 res/layouts/templates/script_file.xml |  2 +-
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/res/layouts/code_editor.xml.lua b/res/layouts/code_editor.xml.lua
index 6cb9ce68..73f3ca46 100644
--- a/res/layouts/code_editor.xml.lua
+++ b/res/layouts/code_editor.xml.lua
@@ -81,13 +81,14 @@ local function refresh_file_title()
 end
 
 function filter_files(text)
+    local pattern_safe = text:pattern_safe();
     local filtered = {}
     for _, filename in ipairs(filenames) do
-        if filename:find(text) then
+        if filename:find(pattern_safe) then
             table.insert(filtered, filename)
         end
     end
-    build_files_list(filtered, text)
+    build_files_list(filtered, pattern_safe)
 end
 
 function on_control_combination(keycode)
@@ -229,15 +230,15 @@ function open_file_in_editor(filename, line, mutable)
     document.saveIcon.enabled = current_file.modified
 end
 
-function build_files_list(filenames, selected)
+function build_files_list(filenames, highlighted_part)
     local files_list = document.filesList
     files_list.scroll = 0
     files_list:clear()
 
     for _, actual_filename in ipairs(filenames) do
         local filename = actual_filename
-        if selected then
-            filename = filename:gsub(selected, "**"..selected.."**")
+        if highlighted_part then
+            filename = filename:gsub(highlighted_part, "**"..highlighted_part.."**")
         end
         local parent = file.parent(filename)
         local info = registry.get_info(actual_filename)
@@ -250,7 +251,8 @@ function build_files_list(filenames, selected)
             name = file.name(filename),
             icon = icon,
             unit = info and info.unit or '',
-            filename = actual_filename
+            filename = actual_filename,
+            open_func = "open_file_in_editor",
         }))
     end
 end
diff --git a/res/layouts/templates/script_file.xml b/res/layouts/templates/script_file.xml
index 94e1afd2..f5d55729 100644
--- a/res/layouts/templates/script_file.xml
+++ b/res/layouts/templates/script_file.xml
@@ -3,7 +3,7 @@
     <label hover-color='#30A0FF'
         pos="20,2"
         interactive="true"
-        onclick='open_file_in_editor("%{filename}")'
+        onclick='%{open_func}("%{filename}")'
         markup='md'
         tooltip='%{unit}'
         sizefunc="-1,-1">

From 04b02323bb6708241a826896d167345c5111a335 Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Sat, 17 May 2025 13:21:25 +0300
Subject: [PATCH 02/11] add xml syntax highlighting

---
 res/devtools/syntax/xml.toml | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 res/devtools/syntax/xml.toml

diff --git a/res/devtools/syntax/xml.toml b/res/devtools/syntax/xml.toml
new file mode 100644
index 00000000..ad591a70
--- /dev/null
+++ b/res/devtools/syntax/xml.toml
@@ -0,0 +1,4 @@
+language = "XML"
+extensions = ["xml"]
+multiline-comment-start = "<!--"
+multiline-comment-end = "-->"

From d3c45fbabcccb2e055eaf4cc46c43d989c172d51 Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Sat, 24 May 2025 16:59:51 +0300
Subject: [PATCH 03/11] fix: act method not called in iframe sub-nodes

---
 src/graphics/ui/elements/InlineFrame.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/graphics/ui/elements/InlineFrame.cpp b/src/graphics/ui/elements/InlineFrame.cpp
index cd01d45b..13625058 100644
--- a/src/graphics/ui/elements/InlineFrame.cpp
+++ b/src/graphics/ui/elements/InlineFrame.cpp
@@ -36,6 +36,7 @@ void InlineFrame::setDocument(const std::shared_ptr<UiDocument>& document) {
 }
 
 void InlineFrame::act(float delta) {
+    Container::act(delta);
     if (document || src.empty()) {
         return;
     }

From 761afe51a57ba79c8f7a96730b238e862094029b Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Sat, 24 May 2025 19:26:57 +0300
Subject: [PATCH 04/11] fix: util::get_texture_region

---
 src/assets/assets_util.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/assets/assets_util.cpp b/src/assets/assets_util.cpp
index a2c68363..ee51d53b 100644
--- a/src/assets/assets_util.cpp
+++ b/src/assets/assets_util.cpp
@@ -9,7 +9,11 @@ util::TextureRegion util::get_texture_region(
 ) {
     size_t sep = name.find(':');
     if (sep == std::string::npos) {
-        return {assets.get<Texture>(name), UVRegion(0,0,1,1)};
+        auto texture = assets.get<Texture>(name);
+        if (texture == nullptr && !fallback.empty()) {
+            return util::get_texture_region(assets, fallback, "");
+        }
+        return {texture, UVRegion(0,0,1,1)};
     } else {
         auto atlas = assets.get<Atlas>(name.substr(0, sep));
         if (atlas) {

From 7a25560bc0ee5bb1c76b926164186db2a16aa331 Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Sat, 24 May 2025 19:28:24 +0300
Subject: [PATCH 05/11] add 'modelviewer' ui element

---
 src/graphics/core/Batch3D.cpp            |  49 ++++++--
 src/graphics/core/Batch3D.hpp            |   5 +-
 src/graphics/core/Shader.cpp             |   6 +
 src/graphics/core/Shader.hpp             |   3 +
 src/graphics/ui/elements/ModelViewer.cpp | 150 +++++++++++++++++++++++
 src/graphics/ui/elements/ModelViewer.hpp |  40 ++++++
 src/graphics/ui/gui_xml.cpp              |  19 +++
 7 files changed, 261 insertions(+), 11 deletions(-)
 create mode 100644 src/graphics/ui/elements/ModelViewer.cpp
 create mode 100644 src/graphics/ui/elements/ModelViewer.hpp

diff --git a/src/graphics/core/Batch3D.cpp b/src/graphics/core/Batch3D.cpp
index 43d161f6..327bb690 100644
--- a/src/graphics/core/Batch3D.cpp
+++ b/src/graphics/core/Batch3D.cpp
@@ -6,6 +6,11 @@
 #include "typedefs.hpp"
 #include "maths/UVRegion.hpp"
 
+namespace {
+    const glm::vec3 SUN_VECTOR(0.528265f, 0.833149f, -0.163704f);
+    const float DIRECTIONAL_LIGHT_FACTOR = 0.3f;
+}
+
 Batch3D::Batch3D(size_t capacity)
     : capacity(capacity) {
 
@@ -31,20 +36,28 @@ void Batch3D::begin(){
 }
 
 void Batch3D::vertex(
-    float x, float y, float z, float u, float v,
-    float r, float g, float b, float a
+    float x,
+    float y,
+    float z,
+    float u,
+    float v,
+    float r,
+    float g,
+    float b,
+    float a
 ) {
     buffer[index].position = {x, y, z};
-    buffer[index].uv = {u, v};
+    buffer[index].uv = {
+        u * region.getWidth() + region.u1, v * region.getHeight() + region.v1};
     buffer[index].color = {r, g, b, a};
     index++;
 }
 void Batch3D::vertex(
-    glm::vec3 coord, float u, float v,
-    float r, float g, float b, float a
+    glm::vec3 coord, float u, float v, float r, float g, float b, float a
 ) {
     buffer[index].position = coord;
-    buffer[index].uv = {u, v};
+    buffer[index].uv = {
+        u * region.getWidth() + region.u1, v * region.getHeight() + region.v1};
     buffer[index].color = {r, g, b, a};
     index++;
 }
@@ -54,7 +67,9 @@ void Batch3D::vertex(
     float r, float g, float b, float a
 ) {
     buffer[index].position = point;
-    buffer[index].uv = uvpoint;
+    buffer[index].uv = {
+        uvpoint.x * region.getWidth() + region.u1,
+        uvpoint.y * region.getHeight() + region.v1};
     buffer[index].color = {r, g, b, a};
     index++;
 }
@@ -86,14 +101,18 @@ void Batch3D::face(
 }
 
 void Batch3D::texture(const Texture* new_texture){
-    if (currentTexture == new_texture)
+    if (currentTexture == new_texture) {
         return;
+    }
     flush();
     currentTexture = new_texture;
-    if (new_texture == nullptr)
+    if (new_texture == nullptr) {
         blank->bind();
-    else
+        region = blank->getUVRegion();
+    } else {
         new_texture->bind();
+        region = currentTexture->getUVRegion();
+    }
 }
 
 void Batch3D::sprite(
@@ -240,6 +259,16 @@ void Batch3D::blockCube(
     cube((1.0f - size) * -0.5f, size, texfaces, tint, shading);
 }
 
+void Batch3D::setRegion(UVRegion region) {
+    this->region = region;
+}
+
+void Batch3D::vertex(const glm::vec3& pos, const glm::vec2& uv, const glm::vec3& norm) {
+    float d = glm::dot(glm::normalize(norm), SUN_VECTOR);
+    d = (1.0f - DIRECTIONAL_LIGHT_FACTOR) + d * DIRECTIONAL_LIGHT_FACTOR;
+    vertex(pos, uv, glm::vec4(d, d, d, 1.0f));
+}
+
 void Batch3D::vertex(
     const glm::vec3& coord, const glm::vec2& uv, const glm::vec4& tint
 ) {
diff --git a/src/graphics/core/Batch3D.hpp b/src/graphics/core/Batch3D.hpp
index c3fb3775..88bec3e4 100644
--- a/src/graphics/core/Batch3D.hpp
+++ b/src/graphics/core/Batch3D.hpp
@@ -3,6 +3,7 @@
 #include "typedefs.hpp"
 #include "commons.hpp"
 #include "MeshData.hpp"
+#include "maths/UVRegion.hpp"
 
 #include <memory>
 #include <cstdlib>
@@ -32,8 +33,8 @@ class Batch3D : public Flushable {
     std::unique_ptr<Texture> blank;
     size_t index;
     glm::vec4 tint {1.0f};
-    
     const Texture* currentTexture;
+    UVRegion region {0.0f, 0.0f, 1.0f, 1.0f};
 
     void vertex(
         float x, float y, float z,
@@ -102,6 +103,8 @@ public:
         const glm::vec4& tint,
         bool shading = true
     );
+    void setRegion(UVRegion region);
+    void vertex(const glm::vec3& pos, const glm::vec2& uv, const glm::vec3& norm);
     void vertex(const glm::vec3& pos, const glm::vec2& uv, const glm::vec4& tint);
     void point(const glm::vec3& pos, const glm::vec4& tint);
     void flush() override;
diff --git a/src/graphics/core/Shader.cpp b/src/graphics/core/Shader.cpp
index 122495ff..626d747b 100644
--- a/src/graphics/core/Shader.cpp
+++ b/src/graphics/core/Shader.cpp
@@ -16,6 +16,7 @@
 namespace fs = std::filesystem;
 
 GLSLExtension* Shader::preprocessor = new GLSLExtension();
+Shader* Shader::used = nullptr;
 
 Shader::Shader(uint id) : id(id){
 }
@@ -25,6 +26,7 @@ Shader::~Shader(){
 }
 
 void Shader::use(){
+    used = this;
     glUseProgram(id);
 }
 
@@ -131,3 +133,7 @@ std::unique_ptr<Shader> Shader::create(
     }
     return std::make_unique<Shader>(id);
 }
+
+Shader& Shader::getUsed() {
+    return *used;
+}
diff --git a/src/graphics/core/Shader.hpp b/src/graphics/core/Shader.hpp
index 5c970d4f..18a14da7 100644
--- a/src/graphics/core/Shader.hpp
+++ b/src/graphics/core/Shader.hpp
@@ -10,6 +10,7 @@
 class GLSLExtension;
 
 class Shader {
+    static Shader* used;
     uint id;
     std::unordered_map<std::string, uint> uniformLocations;
     
@@ -43,4 +44,6 @@ public:
         const std::string& vertexSource, 
         const std::string& fragmentSource
     );
+
+    static Shader& getUsed();
 };
diff --git a/src/graphics/ui/elements/ModelViewer.cpp b/src/graphics/ui/elements/ModelViewer.cpp
new file mode 100644
index 00000000..4f931839
--- /dev/null
+++ b/src/graphics/ui/elements/ModelViewer.cpp
@@ -0,0 +1,150 @@
+#include <glm/ext.hpp>
+#include "ModelViewer.hpp"
+
+#include "assets/Assets.hpp"
+#include "assets/assets_util.hpp"
+#include "graphics/commons/Model.hpp"
+#include "graphics/core/Batch2D.hpp"
+#include "graphics/core/Batch3D.hpp"
+#include "graphics/core/Shader.hpp"
+#include "graphics/core/Framebuffer.hpp"
+#include "graphics/core/DrawContext.hpp"
+#include "window/Window.hpp"
+#include "../GUI.hpp"
+
+// TODO: remove
+#include <GL/glew.h>
+
+using namespace gui;
+
+ModelViewer::ModelViewer(
+    GUI& gui, const glm::vec2& size, const std::string& modelName
+)
+    : Container(gui, size),
+      modelName(modelName),
+      camera(),
+      batch(std::make_unique<Batch3D>(1024)),
+      fbo(std::make_unique<Framebuffer>(size.x, size.y)) {
+    camera.perspective = true;
+    camera.position = glm::vec3(2, 2, 2);
+}
+
+ModelViewer::~ModelViewer() = default;
+
+void ModelViewer::setModel(const std::string& modelName) {
+    this->modelName = modelName;
+}
+
+const std::string& ModelViewer::getModel() const {
+    return modelName;
+}
+
+Camera& ModelViewer::getCamera() {
+    return camera;
+}
+
+const Camera& ModelViewer::getCamera() const {
+    return camera;
+}
+
+void ModelViewer::act(float delta) {
+    Container::act(delta);
+
+    auto& input = gui.getInput();
+    
+    if (!grabbing && hover && input.jclicked(Mousecode::BUTTON_3)) {
+        grabbing = true;
+    }
+    if (grabbing && input.clicked(Mousecode::BUTTON_3)) {
+        auto cursor = input.getCursor();
+        if (input.pressed(Keycode::LEFT_SHIFT)) {
+            center -= camera.right * (cursor.delta.x / size.x) * distance;
+            center += camera.up * (cursor.delta.y / size.y) * distance;
+        } else {
+            rotation.x -= cursor.delta.x / size.x * glm::two_pi<float>();
+            rotation.y -= cursor.delta.y / size.y * glm::two_pi<float>();
+            rotation.y = glm::max(
+                -glm::half_pi<float>(), glm::min(glm::half_pi<float>(), rotation.y)
+            );
+        }
+    } else if (grabbing) {
+        grabbing = false;
+    }
+    if (hover) {
+        distance *= 1.0f - 0.2f * input.getScroll();
+    }
+    camera.rotation = glm::mat4(1.0f);
+    camera.rotate(rotation.y, rotation.x, rotation.z);
+    camera.position = center - camera.front * distance;
+}
+
+void ModelViewer::draw(const DrawContext& pctx, const Assets& assets) {
+    camera.setAspectRatio(size.x / size.y);
+    camera.updateVectors();
+    
+    auto model = assets.get<model::Model>(modelName);
+    if (model == nullptr) {
+        return;
+    }
+    auto& prevShader = Shader::getUsed();
+    
+    fbo->resize(size.x, size.y);
+    {
+        glDisable(GL_SCISSOR_TEST);
+        auto ctx = pctx.sub();
+        ctx.setFramebuffer(fbo.get());
+        ctx.setViewport({size.x, size.y});
+        ctx.setDepthTest(true);
+        display::clear();
+        
+        auto& ui3dShader = assets.require<Shader>("ui3d");
+        ui3dShader.use();
+        ui3dShader.uniformMatrix("u_apply", glm::mat4(1.0f));
+        ui3dShader.uniformMatrix("u_projview", camera.getProjView());
+        batch->begin();
+        for (const auto& mesh : model->meshes) {
+            util::TextureRegion region;
+            if (!mesh.texture.empty() && mesh.texture[0] == '$') {
+                // todo: refactor
+                static std::array<std::string, 6> faces {
+                    "blocks:dbg_north",
+                    "blocks:dbg_south",
+                    "blocks:dbg_top",
+                    "blocks:dbg_bottom",
+                    "blocks:dbg_east",
+                    "blocks:dbg_west",
+                };
+                region = util::get_texture_region(
+                    assets,
+                    faces.at(mesh.texture.at(1) - '0'),
+                    "blocks:notfound"
+                );
+            } else {
+                region = util::get_texture_region(assets, mesh.texture, "blocks:notfound");
+            }
+            batch->texture(region.texture);
+            batch->setRegion(region.region);
+            for (const auto& vertex : mesh.vertices) {
+                batch->vertex(vertex.coord, vertex.uv, vertex.normal);
+            }
+        }
+        batch->flush();
+        glEnable(GL_SCISSOR_TEST);
+    }
+
+    auto pos = calcPos();
+    prevShader.use();
+    auto& batch2d = *pctx.getBatch2D();
+    batch2d.texture(fbo->getTexture());
+    batch2d.rect(pos.x, pos.y, size.x, size.y, 0.0f, 0.0f, 0.0f, UVRegion {}, false, true, glm::vec4{1.0f});
+
+    Container::draw(pctx, assets);
+}
+
+void ModelViewer::setCenter(const glm::vec3& center) {
+    this->center = center;
+}
+
+void ModelViewer::setRotation(const glm::vec3& euler) {
+    this->rotation = euler;
+}
diff --git a/src/graphics/ui/elements/ModelViewer.hpp b/src/graphics/ui/elements/ModelViewer.hpp
new file mode 100644
index 00000000..37fa497e
--- /dev/null
+++ b/src/graphics/ui/elements/ModelViewer.hpp
@@ -0,0 +1,40 @@
+#pragma once
+
+#include <memory>
+#include <string>
+#include "Container.hpp"
+#include "window/Camera.hpp"
+
+class Batch3D;
+class Framebuffer;
+
+namespace gui {
+    class ModelViewer : public Container {
+    private:
+        std::string modelName;
+        Camera camera;
+        std::unique_ptr<Batch3D> batch;
+        std::unique_ptr<Framebuffer> fbo;
+
+        glm::vec3 rotation {};
+        glm::vec3 center {};
+        float distance = 4.0f;
+        bool grabbing = false;
+    public:
+        ModelViewer(GUI& gui, const glm::vec2& size, const std::string& modelName);
+
+        ~ModelViewer();
+
+        void setModel(const std::string& modelName);
+        const std::string& getModel() const;
+
+        Camera& getCamera();
+        const Camera& getCamera() const;
+
+        void act(float delta) override;
+        void draw(const DrawContext& pctx, const Assets& assets) override;
+
+        void setRotation(const glm::vec3& euler);
+        void setCenter(const glm::vec3& center);
+    };
+}
diff --git a/src/graphics/ui/gui_xml.cpp b/src/graphics/ui/gui_xml.cpp
index d393dbae..aaa5a269 100644
--- a/src/graphics/ui/gui_xml.cpp
+++ b/src/graphics/ui/gui_xml.cpp
@@ -19,6 +19,7 @@
 #include "elements/Panel.hpp"
 #include "elements/TextBox.hpp"
 #include "elements/TrackBar.hpp"
+#include "elements/ModelViewer.hpp"
 #include "engine/Engine.hpp"
 #include "frontend/locale.hpp"
 #include "frontend/menu.hpp"
@@ -368,6 +369,23 @@ static std::shared_ptr<UINode> read_split_box(
     return splitBox;
 }
 
+static std::shared_ptr<UINode> read_model_viewer(
+    UiXmlReader& reader, const xml::xmlelement& element
+) {
+    auto model = element.attr("model", "").getText();
+    auto viewer = std::make_shared<ModelViewer>(
+        reader.getGUI(), glm::vec2(), model
+    );
+    read_container_impl(reader, element, *viewer);
+    if (element.has("center")) {
+        viewer->setCenter(element.attr("center").asVec3());
+    }
+    if (element.has("cam-rotation")) {
+        viewer->setRotation(glm::radians(element.attr("cam-rotation").asVec3()));
+    }
+    return viewer;
+}
+
 static std::shared_ptr<UINode> read_panel(
     UiXmlReader& reader, const xml::xmlelement& element
 ) {
@@ -785,6 +803,7 @@ UiXmlReader::UiXmlReader(gui::GUI& gui, scriptenv&& env) : gui(gui), env(std::mo
     add("trackbar", read_track_bar);
     add("container", read_container);
     add("bindbox", read_input_bind_box);
+    add("modelviewer", read_model_viewer);
     add("inventory", read_inventory);
 }
 

From 1366316895f5c9b9fe11ce4c8118dc7544a8a1ea Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Sat, 24 May 2025 20:21:08 +0300
Subject: [PATCH 06/11] add modelviewer test to code_editor.xml

---
 res/layouts/code_editor.xml       | 1 +
 src/graphics/core/DrawContext.hpp | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/res/layouts/code_editor.xml b/res/layouts/code_editor.xml
index 4336ee4f..e684ccec 100644
--- a/res/layouts/code_editor.xml
+++ b/res/layouts/code_editor.xml
@@ -53,6 +53,7 @@
                 text-wrap='false'
                 scroll-step='50'
             ></textbox>
+            <modelviewer size="480" model="stairs" center="0.5,0.5,0.5" cam-rotation="45,-45,0" gravity="top-right"/>
         </container>
         <splitbox orientation="horizontal" split-pos="0.4">
             <panel id="traceback" padding="4" color="#000000A0">
diff --git a/src/graphics/core/DrawContext.hpp b/src/graphics/core/DrawContext.hpp
index 7e1e18d5..d9c61c19 100644
--- a/src/graphics/core/DrawContext.hpp
+++ b/src/graphics/core/DrawContext.hpp
@@ -34,7 +34,7 @@ public:
     Batch2D* getBatch2D() const;
     
     const glm::uvec2& getViewport() const;
-    DrawContext sub(Flushable* flushable=nullptr) const;
+    [[nodiscard]] DrawContext sub(Flushable* flushable=nullptr) const;
 
     void setViewport(const glm::uvec2& viewport);
     void setFramebuffer(Framebuffer* fbo);

From b8e6918dc8a1f4d9375a3bab6ccb88c98c276d64 Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Sat, 24 May 2025 22:22:36 +0300
Subject: [PATCH 07/11] move files panel to separate document

---
 res/layouts/code_editor.xml               |  8 +---
 res/layouts/code_editor.xml.lua           | 49 ++------------------
 res/layouts/files_panel.xml               |  7 +++
 res/layouts/files_panel.xml.lua           | 54 +++++++++++++++++++++++
 res/modules/internal/scripts_registry.lua | 40 +++++++++++------
 res/scripts/post_content.lua              |  2 +-
 6 files changed, 93 insertions(+), 67 deletions(-)
 create mode 100644 res/layouts/files_panel.xml
 create mode 100644 res/layouts/files_panel.xml.lua

diff --git a/res/layouts/code_editor.xml b/res/layouts/code_editor.xml
index e684ccec..02881b44 100644
--- a/res/layouts/code_editor.xml
+++ b/res/layouts/code_editor.xml
@@ -1,12 +1,6 @@
 <splitbox id="editorRoot" orientation="horizontal" split-pos="0.3">
     <splitbox split-pos="0.75">
-        <panel interval="2" color="0" padding="2">
-            <textbox pos="2" padding="4,0,4,0" sub-consumer="filter_files" hint="@Filter"></textbox>
-            <panel id="filesList" color="#00000030" interval="6" padding="4"
-                    size-func="-1,-45" pos="2,38">
-                <!-- content is generated in script -->
-            </panel>
-        </panel>
+        <iframe src="core:files_panel"></iframe>
         <panel id="problemsLog"
             color="#00000030" 
             padding="5,15,5,15">
diff --git a/res/layouts/code_editor.xml.lua b/res/layouts/code_editor.xml.lua
index 73f3ca46..55250c13 100644
--- a/res/layouts/code_editor.xml.lua
+++ b/res/layouts/code_editor.xml.lua
@@ -1,6 +1,5 @@
 local writeables = {}
 local registry
-local filenames
 
 local current_file = {
     filename = "",
@@ -49,6 +48,10 @@ events.on("core:error", function (msg, traceback)
     table.insert(errors_all, full)
 end)
 
+events.on("core:open_in_editor", function(filename, linenum)
+    open_file_in_editor(filename, linenum)
+end)
+
 local function find_mutable(filename)
     local packid = file.prefix(filename)
     if packid == "core" then
@@ -80,17 +83,6 @@ local function refresh_file_title()
         ..(edited and ' *' or '')
 end
 
-function filter_files(text)
-    local pattern_safe = text:pattern_safe();
-    local filtered = {}
-    for _, filename in ipairs(filenames) do
-        if filename:find(pattern_safe) then
-            table.insert(filtered, filename)
-        end
-    end
-    build_files_list(filtered, pattern_safe)
-end
-
 function on_control_combination(keycode)
     if keycode == input.keycode("s") then
         save_current_file()
@@ -230,44 +222,11 @@ function open_file_in_editor(filename, line, mutable)
     document.saveIcon.enabled = current_file.modified
 end
 
-function build_files_list(filenames, highlighted_part)
-    local files_list = document.filesList
-    files_list.scroll = 0
-    files_list:clear()
-
-    for _, actual_filename in ipairs(filenames) do
-        local filename = actual_filename
-        if highlighted_part then
-            filename = filename:gsub(highlighted_part, "**"..highlighted_part.."**")
-        end
-        local parent = file.parent(filename)
-        local info = registry.get_info(actual_filename)
-        local icon = "file"
-        if info then
-            icon = info.type == "component" and "entity" or info.type
-        end
-        files_list:add(gui.template("script_file", {
-            path = parent .. (parent[#parent] == ':' and '' or '/'), 
-            name = file.name(filename),
-            icon = icon,
-            unit = info and info.unit or '',
-            filename = actual_filename,
-            open_func = "open_file_in_editor",
-        }))
-    end
-end
-
 function on_open(mode)
     registry = require "core:internal/scripts_registry"
-    
-    local files_list = document.filesList
 
     document.editorContainer:setInterval(200, refresh_file_title)
 
     clear_traceback()
     clear_output()
-
-    filenames = registry.filenames
-    table.sort(filenames)
-    build_files_list(filenames)
 end
diff --git a/res/layouts/files_panel.xml b/res/layouts/files_panel.xml
new file mode 100644
index 00000000..680b3e43
--- /dev/null
+++ b/res/layouts/files_panel.xml
@@ -0,0 +1,7 @@
+<panel interval="2" color="0" padding="2">
+    <textbox pos="2" padding="4,0,4,0" sub-consumer="filter_files" hint="@Filter"></textbox>
+    <panel id="filesList" color="#00000030" interval="6" padding="4"
+            size-func="-1,-45" pos="2,38">
+        <!-- content is generated in script -->
+    </panel>
+</panel>
diff --git a/res/layouts/files_panel.xml.lua b/res/layouts/files_panel.xml.lua
new file mode 100644
index 00000000..a4d6ca39
--- /dev/null
+++ b/res/layouts/files_panel.xml.lua
@@ -0,0 +1,54 @@
+local registry
+local filenames
+
+function filter_files(text)
+    local pattern_safe = text:pattern_safe();
+    local filtered = {}
+    for _, filename in ipairs(filenames) do
+        if filename:find(pattern_safe) then
+            table.insert(filtered, filename)
+        end
+    end
+    build_files_list(filtered, pattern_safe)
+end
+
+function open_file_in_editor(filename, linenum)
+    events.emit("core:open_in_editor", filename, linenum)
+end
+
+function build_files_list(filenames, highlighted_part)
+    local files_list = document.filesList
+    files_list.scroll = 0
+    files_list:clear()
+
+    for _, actual_filename in ipairs(filenames) do
+        local filename = actual_filename
+        if highlighted_part then
+            filename = filename:gsub(highlighted_part, "**"..highlighted_part.."**")
+        end
+        local parent = file.parent(filename)
+        local info = registry.get_info(actual_filename)
+        local icon = "file"
+        if info then
+            icon = info.type == "component" and "entity" or info.type
+        end
+        files_list:add(gui.template("script_file", {
+            path = parent .. (parent[#parent] == ':' and '' or '/'), 
+            name = file.name(filename),
+            icon = icon,
+            unit = info and info.unit or '',
+            filename = actual_filename,
+            open_func = "open_file_in_editor",
+        }))
+    end
+end
+
+function on_open(mode)
+    registry = require "core:internal/scripts_registry"
+    
+    local files_list = document.filesList
+
+    filenames = registry.filenames
+    table.sort(filenames)
+    build_files_list(filenames)
+end
diff --git a/res/modules/internal/scripts_registry.lua b/res/modules/internal/scripts_registry.lua
index 8933c971..e62be06a 100644
--- a/res/modules/internal/scripts_registry.lua
+++ b/res/modules/internal/scripts_registry.lua
@@ -1,6 +1,6 @@
 local export = {
     filenames = {},
-    classification = {}
+    registry = {}
 }
 
 local function collect_components(dirname, dest)
@@ -9,7 +9,7 @@ local function collect_components(dirname, dest)
         for i, filename in ipairs(files) do
             if file.ext(filename) == "lua" then
                 table.insert(dest, filename)
-                export.classification[filename] = {
+                export.registry[filename] = {
                     type="component", 
                     unit=file.prefix(filename)..":"..file.stem(filename)
                 }
@@ -33,13 +33,13 @@ local function collect_scripts(dirname, dest, ismodule)
     end
 end
 
-local function load_scripts_list()
-    local packs = pack.get_installed()
+local function load_scripts_list(packs)
+    local registry = export.registry
     for _, packid in ipairs(packs) do
         collect_scripts(packid..":modules", export.filenames, true)
     end
     for _, filename in ipairs(export.filenames) do
-        export.classification[filename] = {
+        registry[filename] = {
             type="module", 
             unit=file.join(file.parent(file.prefix(filename)..":"..
                            filename:sub(filename:find("/")+1)),
@@ -51,27 +51,39 @@ local function load_scripts_list()
     end
 end
 
-function export.build_classification()
-    local classification = {}
+local function load_models_list(packs)
+    local registry = export.registry
+    for _, filename in ipairs(file.list("models")) do
+        local ext = file.ext(filename)
+        if ext == "xml" then
+            registry[filename] = {type="model"}
+            table.insert(export.filenames, filename)
+        end
+    end
+end
+
+function export.build_registry()
+    local registry = {}
     for id, props in pairs(block.properties) do
-        classification[props["script-file"]] = {type="block", unit=block.name(id)}
+        registry[props["script-file"]] = {type="block", unit=block.name(id)}
     end
     for id, props in pairs(item.properties) do
-        classification[props["script-file"]] = {type="item", unit=item.name(id)}
+        registry[props["script-file"]] = {type="item", unit=item.name(id)}
     end
     local packs = pack.get_installed()
     for _, packid in ipairs(packs) do
-        classification[packid..":scripts/world.lua"] = {type="world", unit=packid}
-        classification[packid..":scripts/hud.lua"] = {type="hud", unit=packid}
+        registry[packid..":scripts/world.lua"] = {type="world", unit=packid}
+        registry[packid..":scripts/hud.lua"] = {type="hud", unit=packid}
     end
-    export.classification = classification
+    export.registry = registry
     export.filenames = {}
 
-    load_scripts_list()
+    load_scripts_list(packs)
+    load_models_list(packs)
 end
 
 function export.get_info(filename)
-    return export.classification[filename]
+    return export.registry[filename]
 end
 
 return export
diff --git a/res/scripts/post_content.lua b/res/scripts/post_content.lua
index 85d7b28a..249ed65c 100644
--- a/res/scripts/post_content.lua
+++ b/res/scripts/post_content.lua
@@ -63,4 +63,4 @@ cache_names(block)
 cache_names(item)
 
 local scripts_registry = require "core:internal/scripts_registry"
-scripts_registry.build_classification()
+scripts_registry.build_registry()

From ac337a4e654bf57b77e032b20705197c15a4ba2f Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Sun, 25 May 2025 16:32:54 +0300
Subject: [PATCH 08/11] refactor assets library

---
 res/scripts/stdlib.lua                     |  3 --
 src/logic/scripting/lua/libs/api_lua.hpp   |  1 +
 src/logic/scripting/lua/libs/libassets.cpp | 50 ++++++++++++++++++++++
 src/logic/scripting/lua/libs/libcore.cpp   | 38 ----------------
 src/logic/scripting/lua/lua_engine.cpp     |  1 +
 5 files changed, 52 insertions(+), 41 deletions(-)
 create mode 100644 src/logic/scripting/lua/libs/libassets.cpp

diff --git a/res/scripts/stdlib.lua b/res/scripts/stdlib.lua
index 3bc2147e..8915c2b1 100644
--- a/res/scripts/stdlib.lua
+++ b/res/scripts/stdlib.lua
@@ -523,9 +523,6 @@ function time.post_runnable(runnable)
     table.insert(__post_runnables, runnable)
 end
 
-assets = {}
-assets.load_texture = core.__load_texture
-
 -- --------- Deprecated functions ------ --
 local function wrap_deprecated(func, name, alternatives)
     return function (...)
diff --git a/src/logic/scripting/lua/libs/api_lua.hpp b/src/logic/scripting/lua/libs/api_lua.hpp
index 7b4253c5..6e65b790 100644
--- a/src/logic/scripting/lua/libs/api_lua.hpp
+++ b/src/logic/scripting/lua/libs/api_lua.hpp
@@ -15,6 +15,7 @@
 
 // Libraries
 extern const luaL_Reg applib[];
+extern const luaL_Reg assetslib[];
 extern const luaL_Reg audiolib[];
 extern const luaL_Reg base64lib[];
 extern const luaL_Reg bjsonlib[];
diff --git a/src/logic/scripting/lua/libs/libassets.cpp b/src/logic/scripting/lua/libs/libassets.cpp
new file mode 100644
index 00000000..6dbb305c
--- /dev/null
+++ b/src/logic/scripting/lua/libs/libassets.cpp
@@ -0,0 +1,50 @@
+#include "api_lua.hpp"
+
+#include "assets/Assets.hpp"
+#include "coders/png.hpp"
+#include "debug/Logger.hpp"
+#include "engine/Engine.hpp"
+#include "graphics/core/Texture.hpp"
+#include "util/Buffer.hpp"
+
+using namespace scripting;
+
+static void load_texture(
+    const ubyte* bytes, size_t size, const std::string& destname
+) {
+    try {
+        engine->getAssets()->store(png::load_texture(bytes, size), destname);
+    } catch (const std::runtime_error& err) {
+        debug::Logger logger("lua.assetslib");
+        logger.error() << err.what();
+    }
+}
+
+static int l_load_texture(lua::State* L) {
+    if (lua::istable(L, 1)) {
+        lua::pushvalue(L, 1);
+        size_t size = lua::objlen(L, 1);
+        util::Buffer<ubyte> buffer(size);
+        for (size_t i = 0; i < size; i++) {
+            lua::rawgeti(L, i + 1);
+            buffer[i] = lua::tointeger(L, -1);
+            lua::pop(L);
+        }
+        lua::pop(L);
+        load_texture(buffer.data(), buffer.size(), lua::require_string(L, 2));
+    } else {
+        auto string = lua::bytearray_as_string(L, 1);
+        load_texture(
+            reinterpret_cast<const ubyte*>(string.data()),
+            string.size(),
+            lua::require_string(L, 2)
+        );
+        lua::pop(L);
+    }
+    return 0;
+}
+
+const luaL_Reg assetslib[] = {
+    {"load_texture", lua::wrap<l_load_texture>},
+    {NULL, NULL}
+};
diff --git a/src/logic/scripting/lua/libs/libcore.cpp b/src/logic/scripting/lua/libs/libcore.cpp
index 7ebdbc38..4f4c46cd 100644
--- a/src/logic/scripting/lua/libs/libcore.cpp
+++ b/src/logic/scripting/lua/libs/libcore.cpp
@@ -2,12 +2,10 @@
 #include <vector>
 
 #include "api_lua.hpp"
-#include "coders/png.hpp"
 #include "constants.hpp"
 #include "assets/Assets.hpp"
 #include "content/Content.hpp"
 #include "content/ContentControl.hpp"
-#include "debug/Logger.hpp"
 #include "engine/Engine.hpp"
 #include "io/engine_paths.hpp"
 #include "io/io.hpp"
@@ -225,41 +223,6 @@ static int l_get_setting_info(lua::State* L) {
     throw std::runtime_error("unsupported setting type");
 }
 
-static void load_texture(
-    const ubyte* bytes, size_t size, const std::string& destname
-) {
-    try {
-        engine->getAssets()->store(png::load_texture(bytes, size), destname);
-    } catch (const std::runtime_error& err) {
-        debug::Logger logger("lua.corelib");
-        logger.error() << err.what();
-    }
-}
-
-static int l_load_texture(lua::State* L) {
-    if (lua::istable(L, 1)) {
-        lua::pushvalue(L, 1);
-        size_t size = lua::objlen(L, 1);
-        util::Buffer<ubyte> buffer(size);
-        for (size_t i = 0; i < size; i++) {
-            lua::rawgeti(L, i + 1);
-            buffer[i] = lua::tointeger(L, -1);
-            lua::pop(L);
-        }
-        lua::pop(L);
-        load_texture(buffer.data(), buffer.size(), lua::require_string(L, 2));
-    } else {
-        auto string = lua::bytearray_as_string(L, 1);
-        load_texture(
-            reinterpret_cast<const ubyte*>(string.data()),
-            string.size(),
-            lua::require_string(L, 2)
-        );
-        lua::pop(L);
-    }
-    return 0;
-}
-
 static int l_open_folder(lua::State* L) {
     platform::open_folder(io::resolve(lua::require_string(L, 1)));
     return 0;
@@ -322,6 +285,5 @@ const luaL_Reg corelib[] = {
     {"open_folder", lua::wrap<l_open_folder>},
     {"quit", lua::wrap<l_quit>},
     {"capture_output", lua::wrap<l_capture_output>},
-    {"__load_texture", lua::wrap<l_load_texture>},
     {NULL, NULL}
 };
diff --git a/src/logic/scripting/lua/lua_engine.cpp b/src/logic/scripting/lua/lua_engine.cpp
index ca335c49..891b89c7 100644
--- a/src/logic/scripting/lua/lua_engine.cpp
+++ b/src/logic/scripting/lua/lua_engine.cpp
@@ -64,6 +64,7 @@ static void create_libs(State* L, StateType stateType) {
         openlib(L, "__vc_app", applib);
     }
     if (stateType == StateType::BASE || stateType == StateType::SCRIPT) {
+        openlib(L, "assets", assetslib);
         openlib(L, "audio", audiolib);
         openlib(L, "console", consolelib);
         openlib(L, "core", corelib);

From 407184250c0972b6500d064973551b55c3fb681f Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Sun, 25 May 2025 17:16:07 +0300
Subject: [PATCH 09/11] add assets.parse_model

---
 res/modules/internal/scripts_registry.lua  |  2 +-
 src/logic/scripting/lua/libs/libassets.cpp | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/res/modules/internal/scripts_registry.lua b/res/modules/internal/scripts_registry.lua
index e62be06a..db6fc321 100644
--- a/res/modules/internal/scripts_registry.lua
+++ b/res/modules/internal/scripts_registry.lua
@@ -56,7 +56,7 @@ local function load_models_list(packs)
     for _, filename in ipairs(file.list("models")) do
         local ext = file.ext(filename)
         if ext == "xml" then
-            registry[filename] = {type="model"}
+            registry[filename] = {type="model", unit=file.stem(filename)}
             table.insert(export.filenames, filename)
         end
     end
diff --git a/src/logic/scripting/lua/libs/libassets.cpp b/src/logic/scripting/lua/libs/libassets.cpp
index 6dbb305c..1e0d6f20 100644
--- a/src/logic/scripting/lua/libs/libassets.cpp
+++ b/src/logic/scripting/lua/libs/libassets.cpp
@@ -2,8 +2,10 @@
 
 #include "assets/Assets.hpp"
 #include "coders/png.hpp"
+#include "coders/vcm.hpp"
 #include "debug/Logger.hpp"
 #include "engine/Engine.hpp"
+#include "graphics/commons/Model.hpp"
 #include "graphics/core/Texture.hpp"
 #include "util/Buffer.hpp"
 
@@ -44,7 +46,21 @@ static int l_load_texture(lua::State* L) {
     return 0;
 }
 
+static int l_parse_model(lua::State* L) {
+    auto format = lua::require_lstring(L, 1);
+    auto string = lua::require_lstring(L, 2);
+    auto name = lua::require_string(L, 3);
+    
+    if (format == "xml") {
+        engine->getAssets()->store(vcm::parse(name, string), name);
+    } else {
+        throw std::runtime_error("unknown format " + util::quote(std::string(format)));
+    }
+    return 0;
+}
+
 const luaL_Reg assetslib[] = {
     {"load_texture", lua::wrap<l_load_texture>},
+    {"parse_model", lua::wrap<l_parse_model>},
     {NULL, NULL}
 };

From 45f845eb1048d423bd49a53ab8da03fc2a30e79b Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Thu, 29 May 2025 20:53:39 +0300
Subject: [PATCH 10/11] fix: 'box' primitive uv & update stairs model

---
 res/models/stairs.xml                    |  4 ++--
 src/coders/vcm.cpp                       |  4 ++--
 src/graphics/commons/Model.cpp           |  6 +++---
 src/graphics/render/ModelsGenerator.cpp  |  5 ++++-
 src/graphics/ui/elements/ModelViewer.cpp |  3 ++-
 src/maths/UVRegion.hpp                   | 10 ++++++++--
 6 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/res/models/stairs.xml b/res/models/stairs.xml
index 9eeac7a1..5921e08c 100644
--- a/res/models/stairs.xml
+++ b/res/models/stairs.xml
@@ -1,6 +1,6 @@
 <model>
     <box from="0,0,0" to="1,0.5,1" delete="top,south"/>
     <box from="0,0.5,0" to="1,1,0.5" delete="bottom,south"/>
-    <rect from="0,0.5,0.5" right="1,0,0" up="0,0,0.5"/>
-    <rect from="0,0,0" right="1,0,0" up="0,1,0"/>
+    <rect from="0,0.5,0.5" right="1,0,0" up="0,0,0.5" texture="$2"/>
+    <rect from="0,0,0" right="1,0,0" up="0,1,0" texture="$1"/>
 </model>
diff --git a/src/coders/vcm.cpp b/src/coders/vcm.cpp
index 9e87f5ab..e86fc138 100644
--- a/src/coders/vcm.cpp
+++ b/src/coders/vcm.cpp
@@ -14,8 +14,8 @@ static const std::unordered_map<std::string, int> side_indices {
     {"south", 1},
     {"top", 2},
     {"bottom", 3},
-    {"east", 4},
-    {"west", 5},
+    {"west", 4},
+    {"east", 5},
 };
 
 static void perform_rect(const xmlelement& root, model::Model& model) {
diff --git a/src/graphics/commons/Model.cpp b/src/graphics/commons/Model.cpp
index 05835f2a..20d90eb4 100644
--- a/src/graphics/commons/Model.cpp
+++ b/src/graphics/commons/Model.cpp
@@ -77,13 +77,13 @@ void Mesh::addBox(
     if (enabledSides[1]) // south
         addPlane(pos-Z*size, -X*size, Y*size, -Z, uvs[1]);
     if (enabledSides[2]) // top
-        addPlane(pos+Y*size, X*size, -Z*size, Y, uvs[2]);
+        addPlane(pos+Y*size, X*size, -Z*size, Y, uvs[2] * glm::vec2(-1));
     if (enabledSides[3]) // bottom
-        addPlane(pos-Y*size, X*size, Z*size, -Y, uvs[3]);
+        addPlane(pos-Y*size, X*size, Z*size, -Y, uvs[3] * glm::vec2(-1, 1));
     if (enabledSides[4]) // west
         addPlane(pos+X*size, -Z*size, Y*size, X, uvs[4]);
     if (enabledSides[5]) // east
-        addPlane(pos-X*size, Z*size, Y*size, -X, uvs[5]);
+        addPlane(pos-X*size, Z*size, Y*size, -X, uvs[5] * glm::vec2(-1, 1));
 }
 
 void Mesh::scale(const glm::vec3& size) {
diff --git a/src/graphics/render/ModelsGenerator.cpp b/src/graphics/render/ModelsGenerator.cpp
index ccaffa0d..230c4804 100644
--- a/src/graphics/render/ModelsGenerator.cpp
+++ b/src/graphics/render/ModelsGenerator.cpp
@@ -98,7 +98,7 @@ model::Model ModelsGenerator::fromCustom(
     for (size_t i = 0; i < modelBoxes.size(); i++) {
         auto& mesh = model.addMesh("blocks:");
         mesh.lighting = lighting;
-        const UVRegion boxtexfaces[6] = {
+        UVRegion boxtexfaces[6] = {
             get_region_for(modelTextures[i * 6 + 5], assets),
             get_region_for(modelTextures[i * 6 + 4], assets),
             get_region_for(modelTextures[i * 6 + 3], assets),
@@ -106,6 +106,9 @@ model::Model ModelsGenerator::fromCustom(
             get_region_for(modelTextures[i * 6 + 1], assets),
             get_region_for(modelTextures[i * 6 + 0], assets)
         };
+        boxtexfaces[2].scale(glm::vec2(-1));
+        boxtexfaces[5].scale(glm::vec2(-1, 1));
+
         bool enabled[6] {1,1,1,1,1,1};
         mesh.addBox(
             modelBoxes[i].center(),
diff --git a/src/graphics/ui/elements/ModelViewer.cpp b/src/graphics/ui/elements/ModelViewer.cpp
index 4f931839..686a6a01 100644
--- a/src/graphics/ui/elements/ModelViewer.cpp
+++ b/src/graphics/ui/elements/ModelViewer.cpp
@@ -95,6 +95,7 @@ void ModelViewer::draw(const DrawContext& pctx, const Assets& assets) {
         ctx.setFramebuffer(fbo.get());
         ctx.setViewport({size.x, size.y});
         ctx.setDepthTest(true);
+        ctx.setCullFace(true);
         display::clear();
         
         auto& ui3dShader = assets.require<Shader>("ui3d");
@@ -111,8 +112,8 @@ void ModelViewer::draw(const DrawContext& pctx, const Assets& assets) {
                     "blocks:dbg_south",
                     "blocks:dbg_top",
                     "blocks:dbg_bottom",
-                    "blocks:dbg_east",
                     "blocks:dbg_west",
+                    "blocks:dbg_east",
                 };
                 region = util::get_texture_region(
                     assets,
diff --git a/src/maths/UVRegion.hpp b/src/maths/UVRegion.hpp
index 0940cd3c..354c939b 100644
--- a/src/maths/UVRegion.hpp
+++ b/src/maths/UVRegion.hpp
@@ -43,8 +43,8 @@ struct UVRegion {
     }
 
     void scale(float x, float y) {
-        float w = getWidth();
-        float h = getHeight();
+        float w = u2 - u1;
+        float h = v2 - v1;
         float cx = (u1 + u2) * 0.5f;
         float cy = (v1 + v2) * 0.5f;
         u1 = cx - w * 0.5f * x;
@@ -63,4 +63,10 @@ struct UVRegion {
         u2 = vec.z;
         v2 = vec.w;
     }
+
+    UVRegion operator*(const glm::vec2& scale) const {
+        auto copy = UVRegion(*this);
+        copy.scale(scale);
+        return copy;
+    }
 };

From c6f64c34efc92130e808555a9319b6c51d85fc6a Mon Sep 17 00:00:00 2001
From: MihailRis <mexaruc@gmail.com>
Date: Thu, 29 May 2025 21:01:49 +0300
Subject: [PATCH 11/11] improve gui properties-related error messages

---
 src/logic/scripting/lua/libs/libgui.cpp | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/logic/scripting/lua/libs/libgui.cpp b/src/logic/scripting/lua/libs/libgui.cpp
index af317f94..68327c8e 100644
--- a/src/logic/scripting/lua/libs/libgui.cpp
+++ b/src/logic/scripting/lua/libs/libgui.cpp
@@ -490,6 +490,12 @@ static int p_get_scroll(UINode* node, lua::State* L) {
 }
 
 static int l_gui_getattr(lua::State* L) {
+    if (!lua::isstring(L, 1)) {
+        throw std::runtime_error("document name is not a string");
+    }
+    if (!lua::isstring(L, 2)) {
+        throw std::runtime_error("element id is not a string");
+    }
     auto docname = lua::require_string(L, 1);
     auto element = lua::require_string(L, 2);
     if (lua::isnumber(L, 3)) {
@@ -507,6 +513,9 @@ static int l_gui_getattr(lua::State* L) {
         const auto& id = request_node_id(DocumentNode {docnode.document, node});
         return push_document_node(L, id);
     }
+    if (!lua::isstring(L, 3)) {
+        throw std::runtime_error("attribute name is not a string");
+    }
     auto attr = lua::require_string(L, 3);
 
     static const std::unordered_map<
@@ -755,6 +764,15 @@ static int p_set_scroll(UINode* node, lua::State* L, int idx) {
 }
 
 static int l_gui_setattr(lua::State* L) {
+    if (!lua::isstring(L, 1)) {
+        throw std::runtime_error("document name is not a string");
+    }
+    if (!lua::isstring(L, 2)) {
+        throw std::runtime_error("element id is not a string");
+    }
+    if (!lua::isstring(L, 3)) {
+        throw std::runtime_error("attribute name is not a string");
+    }
     auto docname = lua::require_string(L, 1);
     auto element = lua::require_string(L, 2);
     auto attr = lua::require_string(L, 3);